-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ForceTorqueSensorBroadcaster] added force and torque offsets to the parameters + export state interfaces #1215
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1215 +/- ##
==========================================
+ Coverage 80.57% 80.68% +0.11%
==========================================
Files 109 109
Lines 9553 9625 +72
Branches 832 841 +9
==========================================
+ Hits 7697 7766 +69
- Misses 1578 1579 +1
- Partials 278 280 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
force_torque_sensor_broadcaster/src/force_torque_sensor_broadcaster.cpp
Outdated
Show resolved
Hide resolved
Rebased the PR! :) |
…sensor_broadcaster
…xpose interfaces removing the offsets
4bab5f6
to
f7643ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🍪
This PR allows to define of the offsets of the force and torque through the parameter server. It would also be interesting to make it a chainable controller and expose the interfaces to the other controllers.
Now the offsets are removed and published and the same interfaces are exposed as state interfaces to be able to chain by other controllers