Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JTC] Remove deprecation from parameters validation file. (backport #476) #926

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 12, 2023

This is an automatic backport of pull request #476 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got already partially backported by #616, but #924 is having conflicts without this.

IMHO we should add dependencies if we directly use the includes from them.

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cb1ddfb) 45.27% compared to head (58308f9) 44.81%.

❗ Current head 58308f9 differs from pull request most recent head 44eff79. Consider uploading reports for the commit 44eff79 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           humble     #926      +/-   ##
==========================================
- Coverage   45.27%   44.81%   -0.46%     
==========================================
  Files          40       40              
  Lines        3722     3713       -9     
  Branches     1780     1769      -11     
==========================================
- Hits         1685     1664      -21     
- Misses        809      835      +26     
+ Partials     1228     1214      -14     
Flag Coverage Δ
unittests 44.81% <ø> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@aprotyas
Copy link
Member

IMHO we should add dependencies if we directly use the includes from them.

+1

* [JTC] Remove deprecation from parameters validation file.

* Add new dependencies.

* Add missing dependencies

* Update package.xml

(cherry picked from commit b72d0bb)
@bmagyar bmagyar merged commit 37b9d2a into humble Jan 12, 2024
12 of 13 checks passed
@bmagyar bmagyar deleted the mergify/bp/humble/pr-476 branch January 12, 2024 11:32
henrygerardmoore pushed a commit to henrygerardmoore/ros2_controllers that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants