Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make step failures more specific than "bash failed" #143

Open
rotu opened this issue Apr 6, 2020 · 4 comments
Open

Make step failures more specific than "bash failed" #143

rotu opened this issue Apr 6, 2020 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@rotu
Copy link
Contributor

rotu commented Apr 6, 2020

Description

When a step fails, CI should report the step which failed.

Completion Criteria

Make failures report that colcon (or whatever tool) failed instead of bash.

See https://github.com/RoverRobotics-forks/rmw_cyclonedds/runs/565373542?check_suite_focus=true

image

image

@rotu rotu added the enhancement New feature or request label Apr 6, 2020
@rotu rotu changed the title Make step failures less generic Make step failures less generic by not reporting "bash failed" Apr 6, 2020
@rotu rotu changed the title Make step failures less generic by not reporting "bash failed" Make step failures more specific than "bash failed" Apr 6, 2020
@thomas-moulard
Copy link
Member

thomas-moulard commented Apr 6, 2020

If you click on "Invoking bash...", you can see the tool output. You can also download the raw logs.

https://help.github.com/en/actions/configuring-and-managing-workflows/managing-a-workflow-run#downloading-logs

@rotu
Copy link
Contributor Author

rotu commented Apr 6, 2020

I know how to dig into the data. I was calling out that the top-level error is pretty unuseful. This seems to be a negative consequence of wrapping everything in a new bash script as opposed to using ToolRunner directly.

@emersonknapp
Copy link
Contributor

It would be useful to try and parse error output to get more useful data.

@emersonknapp emersonknapp added the help wanted Extra attention is needed label Apr 10, 2020
@rotu
Copy link
Contributor Author

rotu commented Apr 10, 2020

I don't think even parsing output is needed - simply not wrapping all executables in a bash shell would suffice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants