Trigger goal cancelling depending on client state. Fixes #126 #130
+14
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents an undesirable transition from DONE to WAITING_FOR_CANCEL_ACK. See ros#126
|
@mjcarroll This check is copied from cpp to the python client (see #126). Please review. |
jschleicher
approved these changes
May 20, 2019
|
I am also getting the |
+1 |
jschleicher
approved these changes
Aug 10, 2020
|
Thanks for the approval! Who has the authority to hit the merge button? |
|
A subtle ping to @mjcarroll because he did the last release and probably has some rights here 🙂 |
|
The ping is broken 😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents an undesirable transition from DONE to WAITING_FOR_CANCEL_ACK.
See #126