filter_base.hpp: use unsigned long instead of size_t in getParam 2nd … #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems reasonable to me. @shr-project could you rebaseon top of the current ros2 branch? I've fixed the tests now so we can make sure they pass for this PR. |
…parameter * it was added in: ros@25c7d30 but unfortunately on 32bit systems size_t could be the same as unsigned int already defined above and then the build fails with: | filters/2.0.0-1-r0/git/include/filters/filter_base.hpp:219:8: error: 'bool filters::FilterBase<T>::getParam(const string&, size_t&)' cannot be overloaded with 'bool filters::FilterBase<T>::getParam(const string&, unsigned int&)' | 219 | bool getParam(const std::string & name, size_t & value) | | ^~~~~~~~ | filters/2.0.0-1-r0/git/include/filters/filter_base.hpp:201:8: note: previous declaration 'bool filters::FilterBase<T>::getParam(const string&, unsigned int&)' | 201 | bool getParam(const std::string & name, unsigned int & value) | | ^~~~~~ Signed-off-by: Martin Jansa <[email protected]>
|
@shr-project looks like the linter prefers explicitly sized types, could you switch to that? Here is the error from the linter: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…parameter
25c7d30
but unfortunately on 32bit systems size_t could be the same as unsigned int already
defined above and then the build fails with:
| filters/2.0.0-1-r0/git/include/filters/filter_base.hpp:219:8: error: 'bool filters::FilterBase::getParam(const string&, size_t&)' cannot be overloaded with 'bool filters::FilterBase::getParam(const string&, unsigned int&)'
| 219 | bool getParam(const std::string & name, size_t & value)
| | ^~~~~~~~
| filters/2.0.0-1-r0/git/include/filters/filter_base.hpp:201:8: note: previous declaration 'bool filters::FilterBase::getParam(const string&, unsigned int&)'
| 201 | bool getParam(const std::string & name, unsigned int & value)
| | ^~~~~~
Signed-off-by: Martin Jansa [email protected]