Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CI Github action #171

Closed
wants to merge 1 commit into from
Closed

Added CI Github action #171

wants to merge 1 commit into from

Conversation

ahcorde
Copy link

@ahcorde ahcorde commented Jun 28, 2024

No description provided.

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde requested a review from clalancette June 28, 2024 11:00
@ahcorde ahcorde self-assigned this Jun 28, 2024
@ahcorde ahcorde requested a review from mjcarroll July 1, 2024 08:24
Copy link

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually need this? We already have the Rpr jobs running on this repository, and I think it would be better to just stick with that (like we do for the rest of the core packages). Is there a particular reason to add this one?

@ahcorde
Copy link
Author

ahcorde commented Jul 10, 2024

Do we actually need this? We already have the Rpr jobs running on this repository, and I think it would be better to just stick with that (like we do for the rest of the core packages). Is there a particular reason to add this one?

The job is not active (for now), and this one is for free.

@clalancette
Copy link

The job is not active (for now), and this one is for free.

It looks like it is active to me; at least, it seemed to run on this PR, and a couple of other ones that were recently opened. You can see the list of times it ran in https://build.ros2.org/job/Rpr__ros_tutorials__ubuntu_noble_amd64/ .

Mostly I'm just trying to avoid having to maintain this in addition to the Rpr job, and to keep this repository acting like the rest of the core.

@ahcorde
Copy link
Author

ahcorde commented Jul 10, 2024

Sure, closing this then

@ahcorde ahcorde closed this Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants