Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python-snap7 #44413

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add python-snap7 #44413

wants to merge 1 commit into from

Conversation

tgaspar
Copy link
Contributor

@tgaspar tgaspar commented Feb 10, 2025

Please add the following dependency to the rosdep database.

Package name:

python-snap7

Package Upstream Source:

Github repository: https://github.com/gijzelaerr/python-snap7

Purpose of using this:

The python-snap7 Python module provides a wrapper for the Snap7 Ethernet communication suite. This allows writing ROS nodes that interface natively with the Siemens S7 PLCs.

Documentation: https://python-snap7.readthedocs.io/en/latest/

Links to Distribution Packages

PyPI: https://pypi.org/project/python-snap7/

Checks

  • All packages have a declared license in the package.xml
  • This repository has a LICENSE file
  • This package is expected to build on the submitted rosdistro

@tgaspar tgaspar requested a review from a team as a code owner February 10, 2025 13:00
@github-actions github-actions bot added the rosdep Issue/PR is for a rosdep key label Feb 10, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.

ROS Distro Considerations

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.

Need Help?

Please post your questions to Robotics Stack Exchange or refer to the #infra-help channel on our Discord server.


For changes related to rosdep:

  • ✅ New rosdep keys are named appropriately

For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

@tgaspar
Copy link
Contributor Author

tgaspar commented Feb 10, 2025

When creating this PR I was unsure how to properly name the entry given the name of the package. The library is called python-snap7. Following the contribution guidelines I added the python3- prefix as well as the suffix -pip. Given the name of the library, we now have python3-python-snap7-pip entry, which has a repetition of the word python. Is this alright?

@mjcarroll
Copy link
Member

Is this alright?

I think it's fine because you are following the guidelines: python3- + python-snap7 + -pip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rosdep Issue/PR is for a rosdep key
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants