Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name and data_type traits for actions #848

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from

Conversation

nwn
Copy link

@nwn nwn commented Jan 22, 2025

This implements the rosidl_generator_traits::name<>() and rosidl_generator_traits::data_type<>() trait functions for generated actions, similarly to how it's done for messages and services.

Unit tests are added to verify this behaviour, and the prior tests are extended to cover the data_type trait for all interface types.

This implements the `rosidl_generator_traits::name<>()` and
`rosidl_generator_traits::data_type<>()` trait functions for generated
actions, similarly to how it's done for messages and services.

Unit tests are added to verify this behaviour, and also extend the prior
tests to cover the data_type trait for all interface types.

Signed-off-by: Nathan Wiebe Neufeldt <[email protected]>
Copy link

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI

@fujitatomoya
Copy link

Pulls: #848
Gist: https://gist.githubusercontent.com/fujitatomoya/d09973ce52f8b5d19a2f3c1baee099d8/raw/d82c6b8464a0d82b53559e869a514d8a637d0b0b/ros2.repos
BUILD args: --packages-above-and-dependencies rosidl_generator_tests rosidl_generator_cpp
TEST args: --packages-above rosidl_generator_tests rosidl_generator_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15080

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants