chore: update linter configuration

.github/workflows/check-dist.yml

@@ -58,7 +58,6 @@ jobs:
           fi
         id: diff
 
-      # If index.js was different than expected, upload the expected version as an artifact
       - uses: actions/upload-artifact@v3
         if: ${{ failure() && steps.diff.conclusion == 'failure' }}
         with:

.github/workflows/ci.yml

@@ -1,5 +1,5 @@
-name: 'Build'
-on: # rebuild any PRs and main branch changes
+name: Build
+on:
   pull_request:
   push:
     branches:
@@ -58,5 +58,5 @@ jobs:
           env_file: .github/.env
 
       - name: Echo plugin output
-        run: | 
-          echo "EXAMPLE: $EXAMPLE"        
+        run: |
+          echo "EXAMPLE: $EXAMPLE"

.github/workflows/codeql.yml

@@ -1,10 +1,10 @@
-name: "CodeQL"
+name: CodeQL
 
 on:
   push:
-    branches: [ main ]
+    branches: [main]
   pull_request:
-    branches: [ main ]
+    branches: [main]
 
 jobs:
   analyze:
@@ -18,7 +18,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        language: [ 'TypeScript' ]
+        language: [TypeScript]
 
     steps:
       - name: Checkout repository
@@ -34,4 +34,4 @@ jobs:
         uses: github/codeql-action/autobuild@v2
 
       - name: Perform CodeQL Analysis
-        uses: github/codeql-action/analyze@v2
+        uses: github/codeql-action/analyze@v2

README.md

@@ -7,13 +7,13 @@
 ### Basic
 
 ```yaml
-    steps:
-      - uses: actions/checkout@v3
-      - name: Run
-        uses: rotki/action-env@v1      
-        with:
-          env_file: .github/.env
-      - name: Echo plugin output
-        run: | 
-          echo "EXAMPLE: $EXAMPLE"    
-```
+steps:
+  - uses: actions/checkout@v3
+  - name: Run
+    uses: rotki/action-env@v1
+    with:
+      env_file: .github/.env
+  - name: Echo plugin output
+    run: |
+      echo "EXAMPLE: $EXAMPLE"
+```

__tests__/main.test.ts

@@ -1,24 +1,25 @@
-import * as process from 'process';
-import * as cp from 'child_process';
-import * as path from 'path';
-import { expect, test } from 'vitest';
+import * as process from 'node:process';
+import * as cp from 'node:child_process';
+import * as path from 'node:path';
+import { expect, it } from 'vitest';
 import { loadEnv } from '../src/file';
 
-test('loads from env file if the file exists', async () => {
+it('loads from env file if the file exists', () => {
   expect(loadEnv('.github/.env')).toMatchObject({ EXAMPLE: 'example' });
 });
 
-test('returns undefined if the env file does not exist', async () => {
+it('returns undefined if the env file does not exist', () => {
   expect(loadEnv('.unknown_env')).toBeUndefined();
 });
 
 // shows how the runner will run a javascript action with env / stdout protocol
-test('test runs', () => {
-  process.env['INPUT_ENV_FILE'] = '.github/.env';
+it('test runs', () => {
+  process.env.INPUT_ENV_FILE = '.github/.env';
   const np = process.execPath;
   const ip = path.join(__dirname, '..', 'lib', 'main.js');
   const options: cp.ExecFileSyncOptions = {
     env: process.env,
   };
+  // eslint-disable-next-line no-console
   console.log(cp.execFileSync(np, [ip], options).toString());
 });

action.yml

@@ -1,10 +1,10 @@
 name: '@rotki/action-env'
-description: 'Loads environment variables for a job from a file'
-author: 'Rotki Solutions GmbH'
+description: Loads environment variables for a job from a file
+author: Rotki Solutions GmbH
 inputs:
   env_file:
     required: true
-    description: 'The path to the environment file where the variables will be loaded from'
+    description: The path to the environment file where the variables will be loaded from
 runs:
-  using: 'node20'
-  main: 'dist/index.js'
+  using: node20
+  main: dist/index.js

commitlint.config.js

@@ -1,4 +1,3 @@
-// eslint-disable-next-line import/no-commonjs
 module.exports = {
   extends: ['@commitlint/config-conventional'],
 };

eslint.config.js

@@ -0,0 +1,26 @@
+const rotki = require('@rotki/eslint-config').default;
+const github = require('eslint-plugin-github');
+
+module.exports = rotki({
+  typescript: {
+    tsconfigPath: 'tsconfig.eslint.json',
+  },
+  stylistic: true,
+  formatters: true,
+}, {
+  files: ['src/**/*.ts'],
+  plugins: {
+    github,
+  },
+  rules: {
+    'github/array-foreach': 'error',
+    'github/no-implicit-buggy-globals': 'error',
+    'github/no-then': 'error',
+    'github/no-dynamic-script-tag': 'error',
+  },
+}, {
+  files: ['**/*.ts'],
+  rules: {
+    'perfectionist/sort-objects': 'error',
+  },
+});

package.json

@@ -2,37 +2,35 @@
   "name": "@rotki/action-env",
   "version": "2.0.0",
   "private": true,
+  "packageManager": "[email protected]",
   "description": "Loads environment variables from a .env file",
+  "keywords": [
+    "actions",
+    "node",
+    "setup"
+  ],
+  "license": "AGPL-3.0",
+  "repository": {
+    "type": "git",
+    "url": "git+https://github.com/rotki/action-env.git"
+  },
+  "author": "Rotki Solutions GmbH <[email protected]>",
   "main": "lib/main.js",
-  "packageManager": "[email protected]",
   "scripts": {
     "build": "tsc",
-    "format": "prettier --write '**/*.ts'",
-    "format-check": "prettier --check '**/*.ts'",
-    "lint": "eslint src/**/*.ts",
+    "lint": "eslint .",
     "package": "ncc build --source-map --license licenses.txt",
     "test": "vitest",
-    "all": "npm run build && npm run format && npm run lint && npm run package && npm test",
+    "all": "npm run build && npm run lint && npm run package && npm test",
     "preinstall": "npx only-allow pnpm",
     "release": "bumpp --no-push"
   },
-  "repository": {
-    "type": "git",
-    "url": "git+https://github.com/rotki/action-env.git"
-  },
-  "keywords": [
-    "actions",
-    "node",
-    "setup"
-  ],
-  "author": "Rotki Solutions GmbH <[email protected]>",
-  "license": "AGPL-3.0",
   "dependencies": {
     "@actions/core": "1.10.1",
     "dotenv": "16.4.1"
   },
   "devDependencies": {
-    "@rotki/eslint-config": "1.1.2",
+    "@rotki/eslint-config": "2.4.4",
     "@types/node": "20.11.6",
     "@vercel/ncc": "0.38.1",
     "bumpp": "9.3.0",