-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(RuiTextField): add labelPosition prop #294
Merged
lukicenturi
merged 16 commits into
rotki:develop
from
cleanerzkp:textfield-labelposition
Oct 29, 2024
Merged
feat(RuiTextField): add labelPosition prop #294
lukicenturi
merged 16 commits into
rotki:develop
from
cleanerzkp:textfield-labelposition
Oct 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelsos
reviewed
Oct 23, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #294 +/- ##
==========================================
Coverage ? 85.00%
==========================================
Files ? 115
Lines ? 10364
Branches ? 1272
==========================================
Hits ? 8810
Misses ? 1554
Partials ? 0 ☔ View full report in Codecov by Sentry. |
lukicenturi
approved these changes
Oct 29, 2024
@cleanerzkp please continue with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also add new style for outside label
Closes #(issue_number)