Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RuiTextField): add labelPosition prop #294

Merged
merged 16 commits into from
Oct 29, 2024

Conversation

cleanerzkp
Copy link
Contributor

also add new style for outside label

Closes #(issue_number)

@cleanerzkp cleanerzkp requested a review from a team as a code owner October 23, 2024 15:25
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 95.31250% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@477eead). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/components/forms/text-field/RuiTextField.vue 94.73% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #294   +/-   ##
==========================================
  Coverage           ?   85.00%           
==========================================
  Files              ?      115           
  Lines              ?    10364           
  Branches           ?     1272           
==========================================
  Hits               ?     8810           
  Misses             ?     1554           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukicenturi
Copy link
Contributor

lukicenturi commented Oct 24, 2024

image image image

@lukicenturi
Copy link
Contributor

image

@lukicenturi
Copy link
Contributor

@cleanerzkp please continue with the filled version in new PR

@lukicenturi lukicenturi merged commit 77c573c into rotki:develop Oct 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants