Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use ComponentView in all pages #296

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

kelsos
Copy link
Member

@kelsos kelsos commented Oct 28, 2024

Closes #(issue_number)

@kelsos kelsos requested a review from a team as a code owner October 28, 2024 18:51
@kelsos kelsos merged commit 96a42dd into rotki:main Oct 28, 2024
5 checks passed
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@1b111c0). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #296   +/-   ##
=======================================
  Coverage        ?   84.97%           
=======================================
  Files           ?      115           
  Lines           ?    10388           
  Branches        ?     1271           
=======================================
  Hits            ?     8827           
  Misses          ?     1561           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelsos kelsos deleted the cleanup/example branch October 28, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants