Xamlbasic #5
Open
Xamlbasic #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endencyObject This change removes the coupling between the `NativeViewHierarchyManager`, `IViewManager`, and `IViewParentManager` and `DependencyObject`. It affords the opportunity to use alternative base classes other than `DependencyObject`, such as handles to lower level XAML APIs. There are a few notable exceptions to the decoupling in this change: - LayoutAnimation still depends on FrameworkElement - UIManager.[measure|measureInWindow|findSubViewIn] still depend on UIElement. - Touch handling still enumerates the DependencyObject sub-tree.
The ReactStylesDiffMap is not a useful abstraction. Everything in react-native-windows is tightly coupled with Newtonsoft.Json. If we decide to abandon that dependency, then we should revisit a ReactNative specific JSON data model abstraction. In the meantime, since we're making breaking changes to IViewManager anyway, it's a good time to eliminate this class.
We originally replaced `prop` with `property` throughout the codebase because at one point code analysis complained that `prop` was not a real word. Prop is still not a real word, but we are not using code analysis currently and prop is a well-known term in React.
Includes base classes for views and view parents.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request:
(You can skip this if you're fixing a typo or adding an app to the Showcase.)
Explain the motivation for making this change. What existing problem does the pull request solve?
Prefer small pull requests. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.
Test plan (required)
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.
Make sure tests pass on both Travis and Circle CI.
Code formatting
Look around. Match the style of the rest of the codebase. See also the simple style guide.
For more info, see the "Pull Requests" section of our "Contributing" guidelines.