Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to reflect API changes #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

corpix
Copy link

@corpix corpix commented May 9, 2023

Hi

I have found this package is broken with Emacs 28, so I've fixed it and updated types list. What do you think?

@corpix corpix changed the title Make it working Update to reflect API changes May 9, 2023
@corpix
Copy link
Author

corpix commented May 9, 2023

Looks like this is where problem was added 5d7791f
sql-add-product does takes &rest plist https://github.com/emacs-mirror/emacs/blob/7791907c3852e6ec197352e1c3d3dd8487cc04f5/lisp/progmodes/sql.el#LL2680C12-L2680C12, which makes this argument not a valid plist (&rest will wrap plist into the another list '(...) => '((...)))

UPD: some more code archeology! Looks like initial change by @krosenmann was correct at the time of writing, but sql-add-product API was changed by mistake emacs-mirror/emacs@82a632e#diff-6b3cab81d06a20cc8ee5273e8d9c571cc92b908f2c5f79f864bdf2886e51a1cbR2686

@rschwarz
Copy link
Owner

Thanks for the effort. This project was really a one-off for me to help with a particular workflow back then.

Maybe it would be better for me to archive this repo and point to your fork of it?

@corpix
Copy link
Author

corpix commented May 11, 2023

Might be an option, would love to maintain and use this package

@vkocubinsky
Copy link

hi, like to say thanks to @rschwarz and @corpix. i use emacs 29, i was able to run @corpix version of sql-clickhouse.el.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants