-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extract worksheet reading code from functions #7
base: master
Are you sure you want to change the base?
Conversation
Nice! I have more packages you could do this to if you'd like 😀
I'll try and get through the actual vignette soon |
I think quarantining of the style code could be achieved at the same time as my suggestion to create a workbook registration function (that treats all worksheets equally and gathers a bit of info on them), should you choose to accept it. |
This is also me just exploring all the files in the unzipped xlsx. And then exposing anything that looks valuable. I'm sure this has lots of overlap with existing linen::workbook.
similar to xlsx_read_workbook() but does less: only reads from the single file xl/workbook.xml
# Conflicts: # DESCRIPTION
so I need to be more specific here
# Conflicts: # DESCRIPTION # R/rexcel-package.r
This is not a genuine PR @richfitz. I've created a faux vignette, where I unpack all the code necessary to read the data from a workbook with one sheet. I propose this PR/vignette as a way to have a concrete conversation as I figure out how
rexcel
works. Eventually we could comment around specific lines. But first, can I get your high-level reaction?rexcel
's reading could be made simpler, but of course I don't have specific proposals yet! Is that also your sense or do you think there aren't any major simplifications available?rexcel
, because it's driven the current specs oflinen
. This is more a comment than question.