Fix build for Rails main, Rails 7.0 and Ruby 3.4 #2829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
changed the title
JonRowe
force-pushed
the
fix-verify-mailer-preview
branch
3 times, most recently
from
a1765e3 to
aa2b3b5
Compare
JonRowe
force-pushed
the
fix-verify-mailer-preview
branch
2 times, most recently
from
1ffd318 to
7b49919
Compare
JonRowe
added a commit
that referenced
this pull request
Feb 5, 2025
Fix build for Rails main, Rails 7.0 and Ruby 3.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to the internals made openssl a requirement which isn't loaded in our verify mailer test, so fix that, and remove un-needed skip that wasn't doing anything anyway.