fix(shiny-preset): Empty nav links don't get padding (#1170)

* fix(shiny-preset): Empty nav links don't get padding * docs: Add NEWS item * Resave distributed files (GitHub Action)
rstudio · Jan 17, 2025 · 7e1e98b · 7e1e98b
1 parent 897dcb5
commit 7e1e98b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -20,6 +20,8 @@
 
 * `input_switch()` and `input_dark_mode()` can be included in Shiny's [bookmarking feature](https://shiny.posit.co/r/articles/share/bookmarking-state/). (#1166)
 
+* Fixed an issue with the Shiny preset (`bs_theme(5, "shiny")`) that caused a floating underling to appear when a `nav_panel_hidden()` was used and active. (#1170)
+
 # bslib 0.8.0
 
 ## Breaking changes

diff --git a/inst/builtin/bs5/shiny/_rules.scss b/inst/builtin/bs5/shiny/_rules.scss
@@ -215,7 +215,7 @@ $bslib-checkbox-radio-margin-right: 0.35em !default;
   --#{$prefix}link-hover-color: rgba(var(--bs-body-color-rgb), 0.8);
   --#{$prefix}nav-link-font-size: 0.875rem;
 
-  .nav-link {
+  .nav-link:not(:empty) {
     padding-left: 5px !important;
     padding-right: 5px !important;
 

diff --git a/inst/css-precompiled/5/bootstrap.min.css b/inst/css-precompiled/5/bootstrap.min.css