-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(theme): Branded theming via brand.yml #1148
Merged
+2,726
−23
Merged
Changes from all commits
Commits
Show all changes
101 commits
Select commit
Hold shift + click to select a range
11e15d7
feat(resolve_bs_preset): Support brand
gadenbuie 4a68bf6
feat: read_brand_yml (not exported)
gadenbuie 01f3422
feat: Brand theme includes base theme from brand.yml
gadenbuie 630c24d
feat: Add brand example app
gadenbuie ee57d31
feat: Add brand base and colors as first brand layer
gadenbuie b8b3c73
feat: Add brand defaults
gadenbuie a14f5d1
feat: Add brand.color defaults
gadenbuie 1600c20
feat: Add brand typography
gadenbuie 8455b53
chore: consistent return values
gadenbuie debb707
feat: Add brand fonts
gadenbuie eb31cca
chore: tweak and improve example app
gadenbuie 8004201
fix: ensure return type consistency
gadenbuie 67d6bb8
feat: include `brand` as an attribute of the bslib theme object
gadenbuie 4fb63dd
feat: Example app updates
gadenbuie e193a34
Resave data (GitHub Action)
gadenbuie 74ed9bc
Update website deps (GitHub Action)
gadenbuie 2477324
chore: download font files on first run
gadenbuie c632ee7
feat: File fonts can be URLs
gadenbuie 77c5ad9
tests: Update tests
gadenbuie d0110bb
chore: Add {lobstr} to Suggests
gadenbuie a45954c
fix: Remove `|>` syntax, add clarifying comment
gadenbuie 09e5e94
feat: Normalize `brand.color` on read and detect cycles
gadenbuie 80d4c7f
Resave data (GitHub Action)
gadenbuie 038f6a2
tests: maybe_convert_font_size_to_rem
gadenbuie 9bab3c1
tests(b_get_color): Add test for null case
gadenbuie 98ac4ef
chore: remove unused function
gadenbuie dfd9c9d
feat(brand_resolve_preset): Use S3 class for many ways to create a br…
gadenbuie 16beb21
feat: "brand" is now a builtin theme
gadenbuie f105690
chore: don't use str because it comes from {utils}
gadenbuie b4cda0e
tests: normalize `brand$path`
gadenbuie 9b522f9
chore: style
gadenbuie ab1816b
chore: Add {tools} and {utils} to Suggests
gadenbuie d09479b
feat: inline brand definitions are allowed
gadenbuie 8fe76a7
tests: update snapshot
gadenbuie 8e25fbe
tests: fix path test for Windows
gadenbuie 57a7c6e
fix: actually fix path comparison
gadenbuie b835e66
Merged origin/main into feat/theme-brand-yml
gadenbuie 3093ae4
feat: Update _brand-yml.scss after `$default` fix
gadenbuie b6314ca
chore: rename brand example app file
gadenbuie dfd71ab
feat(bs_theme): Separate `preset` and `brand` arguments
gadenbuie 6792e29
tests: Update brand theming tests
gadenbuie 95101fb
`devtools::document()` (GitHub Actions)
gadenbuie 86450eb
Update website deps (GitHub Action)
gadenbuie 18bf568
fix: remove unused call
gadenbuie 3168442
feat: brand_resolve(NULL) finds brand if available, silent if not
gadenbuie 5413088
tests: clean up unused tests
gadenbuie 6aa9939
`devtools::document()` (GitHub Actions)
gadenbuie 96735bd
test: `brand_resolve(FALSE)` returns `NULL`
gadenbuie 4cd5cd4
chore: remove print method and lobstr dependency
gadenbuie 2a06507
tests(brand_resolve_preset)
gadenbuie a56f412
Add white space to trigger CI
schloerke eca2cc0
chore: undo changes to `resolve_bs_preset()`
gadenbuie 4295d22
chore: use `sass::sass_file()`
gadenbuie 66e4e9f
feat: warn if brand is used with Bootstrap <= 4
gadenbuie 19c3cd1
fix: Add missing font family to error message
gadenbuie 5f2e0c7
refactor: Use `abort()` across the board
gadenbuie 292cf27
chore: trim whitespace of css value
gadenbuie a1002b9
refactor: early return on its own
gadenbuie 5029146
fix: oops
gadenbuie 4dd54a2
refactor: simplify `path_is_file()`
gadenbuie 9e1c265
chore: add comment that we're borrowing from tools::file_ext()
gadenbuie 80034f5
chore: suggested imports
gadenbuie 4d1d405
Merge branch 'main' into feat/theme-brand-yml
gadenbuie 85c6dd5
docs: make note of brand example
gadenbuie 8c458e1
`yarn build` (GitHub Actions)
gadenbuie fcab93c
docs: callouts for h3-h5
gadenbuie 0c9b04c
docs: Add brand.yml article
gadenbuie 93474b3
docs(article): Edits and moving around
gadenbuie e0a278c
chore: remove unused brand.yml logo
gadenbuie 95762f3
chore: fix typo in brand.yml
gadenbuie b0c6d00
feature(app): live edit brand.yml in the app
gadenbuie 716c5c8
feat: Add light-weight prism-code-editor
gadenbuie 7b1ed31
chore: Use env for error message storage
gadenbuie 35a59ab
feat: Toggle editor from navbar
gadenbuie 68e5c1b
feat: Use ExtendedTask for long-running plot
gadenbuie e66040f
chore: clean up logo section of example _brand.yml
gadenbuie 3b4585d
chore: format
gadenbuie c957238
Resave data (GitHub Action)
gadenbuie ec1151f
chore: strip ansi chars from error message
gadenbuie a0a89ce
chore: increase theme update delay
gadenbuie 2bebef8
docs: Add news item
gadenbuie 15ac514
Update website deps (GitHub Action)
gadenbuie 77773af
chore: remove dev code from example app
gadenbuie 3afbf28
rename: `b_get()` -> `brand_pluck()`, etc.
gadenbuie 95af06f
fix: Set default google font style
gadenbuie 7210884
fix: `.brand-font-{family}` class name
gadenbuie ee47eef
chore: add a comment that fonts aren't dynamically updated
gadenbuie 1aff7f7
chore: format
gadenbuie 70ffdc0
Update website deps (GitHub Action)
gadenbuie 90dd65c
chore: simplify ansi color code removal
gadenbuie c2c5011
chore: remove pkgload local dev code (again)
gadenbuie 9846f12
chore: tweak error message
gadenbuie bd5b953
docs(bs_theme): `brand=NULL` is the default
gadenbuie 0476707
Merge branch 'main' into feat/theme-brand-yml
gadenbuie 4602718
chore: finalize example _brand.yml
gadenbuie 2e3c477
refactor: Rename example `brand.yml`
gadenbuie 9ef3cf8
feat: Only allow saving the `_brand.yml` file if used as template
gadenbuie 1f4bb0c
`devtools::document()` (GitHub Actions)
gadenbuie 25a1f4a
feat: put editor in a card in a black-background sidebar
gadenbuie 825ff70
fix(brand_color_pluck): Return `NULL` values, otherwise assert string…
gadenbuie 627176a
refactor: simplify null/string check
gadenbuie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to update this link before release (remove
dev
from URL)