feat: use _brand.yml for pkgdown
#1176
Conversation
| @@ -247,38 +247,4 @@ footer { | |||
| img:active { | |||
| opacity: 1; | |||
| } | |||
|
|
|||
| // github-dark.css // | |||
There was a problem hiding this comment.
No longer needed, pkgdown supports template.theme-dark
| link-color: "#216B73" | ||
| link-color-dark: "#cef4f9" | ||
| link-decoration: underline dotted | ||
| brand: pkgdown/_brand.yml |
There was a problem hiding this comment.
pkgdown renders from the root folder, so we wouldn't need this if we had _brand.yml in the package root. (We wouldn't even need bslib.brand, but we could force it with bslib.brand: true.)
In our case, however, we don't want our example or test apps to accidentally pick up _brand.yml, so I've moved both it and _pkgdown.yml into pkgdown/. I can undo moving _pkgdown.yml if you want, but I generally prefer to keep all pkgdown things there.
| docsearch: | ||
| api_key: 53fd87c79a13e431b4298611470d023a | ||
| index_name: bslib |
There was a problem hiding this comment.
I'm pretty certain we're using pkgdown's built in search these days.
| defaults: | ||
| bootstrap: | ||
| defaults: | ||
| link-color-dark: "#cef4f9" |
There was a problem hiding this comment.
This is a good argument for color and background-color to take light/dark variants in brand.yml (something we'll think about doing in the future).
typography:
link:
color:
light: "#216b73"
dark: "#cef4f9"
No description provided.