Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Replace with_mock() with with_mocked_bindings() #970

Merged
merged 1 commit into from
Jan 13, 2025
Merged

tests: Replace with_mock() with with_mocked_bindings() #970

merged 1 commit into from
Jan 13, 2025

Conversation

gadenbuie
Copy link
Member

Fixes #969

@gadenbuie gadenbuie requested a review from schloerke January 13, 2025 19:55
schloerke
schloerke approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@schloerke schloerke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@gadenbuie gadenbuie merged commit 439f293 into main Jan 13, 2025
12 checks passed
@gadenbuie gadenbuie deleted the chore/remove-with-mock branch January 13, 2025 20:34
schloerke added a commit that referenced this pull request Feb 5, 2025
@schloerke
Merge branch 'main' into delay_path_value
4d39077 
* main: (28 commits)
  feat: add `excel` serializer/parser (#975)
  ci: Error on spelling (#981)
  docs: Improve forward docs a bit (#978)
  Fix file path tests on windows (#979)
  bug: Update default debug behaviour to `FALSE` (#976)
  perf: Avoid disk I/O during parsing (#972)
  docs: Add note on annotating required parameters (#971)
  Allows port to be specified as an environment variable (#963)
  tests: Replace `with_mock()` with `with_mocked_bindings()` (#970)
  feat(serializer): Add support for ragg and svglite (#964)
  chore: Fix pkgdown warnings. Use lifecycle inline R badges (#965)
  v1.2.2 release candidate (#948)
  bug: Use `{rlang}` instead of `{ellipsis}` (#958)
  docs: Update URLs (#954)
  docs: fix table spacing (#951)
  docs: change link to httr2 in routing and input vignette (#944)
  Specify interactive mode in doc (#932)
  Fall back to sys env var if R option doesn't exist (#934)
  Add support for quoted boundary for multipart request parsing. (#924)
  chore: Remove parse comment to match implementation (#931)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schloerke schloerke schloerke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

with_mock() is going away
2 participants
@gadenbuie @schloerke