Pass --linter=rubocop --test=rspec to bundle gem
#21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambostock
commented
Feb 4, 2023
| @@ -7,7 +7,7 @@ def initialize(name) | |||
| end | |||
|
|
|||
| def generate | |||
| system('bundle', 'gem', '--test=rspec', name, exception: true) | |||
| system('bundle', 'gem', '--linter=rubocop', '--test=rspec', name, exception: true) | |||
There was a problem hiding this comment.
We could also build on this by enabling some InternalAffairs cops by default.
For example, InternalAffairs/InheritDeprecatedCopClass is probably a good one to enable.
The generator expects to patch RSpec files, so specifying anything other than `rspec` as the test framework would break generation. Therefore, it makes sense to specify it ourselves, and save the user the time of having to select it. By doing this, we can also remove the patch to add the gem, since Bundler will handle that for us.
It seems very unlikely that someone would want to generate a RuboCop extension, but use a linter other than RuboCop, so let's save the user the time.
sambostock
force-pushed
the
pass-default-options-to-bundle-gem
branch
from
03583ea to
40d38c9
Compare
|
This turns out to be similar to #10, but takes a different approach, by forcing RSpec, rather than checking for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generator expects to patch RSpec files, so specifying anything other than
rspecas the test framework would break generation. Therefore, it makes sense to specify it ourselves, and save the user the time of having to select it.It also seems very unlikely that someone would want to generate a RuboCop extension, but use a linter other than RuboCop, so let's save the user the time.