[Fix #1031] Make Lint/SafeNavigationChain allow presence_in
#1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rubocop#1031. This PR makes `Lint/SafeNavigationChain` allow `presence_in`. It adds `presence_in` method to the default of the RuboCop core: https://github.com/rubocop/rubocop/blob/v1.56.0/config/default.yml#L2265-L2271
koic
changed the title
Lint/SafeNavigationChain allowe presence_inLint/SafeNavigationChain allow presence_in
koic
force-pushed
the
make_lint_safe_navigation_chain_allow_presence_in
branch
from
b11b291
to
0a1d922
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1031.
This PR makes
Lint/SafeNavigationChainallowpresence_in.It adds
presence_inmethod to the default of the RuboCop core: https://github.com/rubocop/rubocop/blob/v1.56.0/config/default.yml#L2265-L2271Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.