Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Rails/TimeUnitNumberForm cop #1074

Closed

Conversation

koic
Copy link
Member

@koic koic commented Aug 22, 2023

This PR adds new Rails/TimeUnitNumberForm cop.

It checks the usage of singular and plural method forms for year, week, month, day, hour, minute, and second.

# bad
1.hours
42.minute

# good
1.hour
42.minutes

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@koic koic force-pushed the add_new_rails_time_unit_pluralization_cop branch from 48abb37 to 87a5013 Compare August 22, 2023 08:06
This PR adds new `Rails/TimeUnitNumberForm` cop.

It checks the usage of singular and plural method forms for
`year`, `week`, `month`, `day`, `hour`, `minute`, and `second`.

```ruby
# bad
1.hours
42.minute

# good
1.hour
42.minutes
```
@koic koic changed the title Add new Rails/TimeUnitPluralization cop Add new Rails/TimeUnitNumberForm cop Aug 22, 2023
@koic koic force-pushed the add_new_rails_time_unit_pluralization_cop branch from 87a5013 to 1f352a1 Compare August 22, 2023 16:14
@Earlopain
Copy link
Contributor

What is the difference to Rails/PluralizationGrammar?

@koic
Copy link
Member Author

koic commented Aug 24, 2023

@Earlopain Right! I'm going to close this PR. Thank you!

@koic koic closed this Aug 24, 2023
@koic koic deleted the add_new_rails_time_unit_pluralization_cop branch August 24, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants