[Doc] Remove missing style guide link from Rails/DefaultScope
#1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masato-bkn
force-pushed
the
remove_style_guide_link_from_rails_default_scope
branch
from
672cc6b
to
d7e7be5
Compare
koic
reviewed
Oct 2, 2023
| @@ -0,0 +1 @@ | |||
| * [#1136](https://github.com/rubocop/rubocop-rails/pull/1136): Remove missing style guide link from `Rails/DefaultScope`. ([@masato-bkn][]) | |||
There was a problem hiding this comment.
Can you remove this changelog entry? Because this change doesn't impact users.
There was a problem hiding this comment.
Thank you for the review. I've addressed it.
masato-bkn
force-pushed
the
remove_style_guide_link_from_rails_default_scope
branch
from
d7e7be5
to
27dd7e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the style guide link from
Rails/DefaultScopebecause the URL is missing.The style guide section was not merged in rubocop/rails-style-guide#267.
Before submitting the PR make sure the following are checked:
[ ] Commit message starts with[Fix #issue-number](if the related issue exists).master(if not - rebase it).[ ] Added tests.bundle exec rake default. It executes all tests and runs RuboCop on its own code.[X] Added an entry (file) to the changelog folder named{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.[ ] If this is a new cop, consider making a corresponding update to the Rails Style Guide.