Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #1377] Fix an error for Rails/EnumSyntax #1378

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

koic
Copy link
Member

@koic koic commented Oct 18, 2024

Fixes #1377

This PR fixes an error for Rails/EnumSyntax when positional arguments are used and options are not passed as keyword arguments.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@koic koic force-pushed the fix_an_error_for_rails_enum_syntax branch from 0cb3038 to 3ca913d Compare October 18, 2024 03:12
Fixes rubocop#1377

This PR fixes an error for `Rails/EnumSyntax`
when positional arguments are used and options are not passed as keyword arguments.
@koic koic force-pushed the fix_an_error_for_rails_enum_syntax branch from 3ca913d to 94a8370 Compare October 18, 2024 03:17
@koic koic merged commit f66b8f7 into rubocop:master Oct 18, 2024
14 checks passed
@koic koic deleted the fix_an_error_for_rails_enum_syntax branch October 18, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rails/EnumSyntax crash when the 3rd argument is not kwargs
1 participant