Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Bitwise Predicate Methods" rule #944

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Add "Bitwise Predicate Methods" rule #944

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions README.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5808,6 +5808,32 @@ if x == 0
end
----

=== Bitwise Predicate Methods [[bitwise-predicate-methods]]

Prefer bitwise predicate methods over direct comparison operations.

[source,ruby]
----
# bad - checks any set bits
(variable & flags).positive?

# good
variable.anybits?(flags)

# bad - checks all set bits
(variable & flags) == flags

# good
variable.allbits?(flags)

# bad - checks no set bits
(variable & flags).zero?
(variable & flags) == 0

# good
variable.nobits?(flags)
----

=== No Cryptic Perlisms [[no-cryptic-perlisms]]

Avoid using Perl-style special variables (like `$:`, `$;`, etc).
Expand Down