Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Little-Rubyist to reviewer for activerecord #585

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Add Little-Rubyist to reviewer for activerecord #585

merged 1 commit into from
Jun 4, 2024

Conversation

Little-Rubyist
Copy link
Contributor

relation: #558 (comment)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

@Little-Rubyist Thanks for your contribution!

Please follow the instructions below for each change.
See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

  • /merge: Merge this PR if CI passes

activerecord

You changed RBS files for an existing gem.
You need to get approval from the reviewers of this gem.

@hibariya, @ksss, please review this pull request.
If this change is acceptable, please make a review comment including APPROVE from here.
Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR.
Just comment /merge to merge this PR.

hibariya
hibariya reviewed Jun 4, 2024
View reviewed changes
Copy link
Contributor

@hibariya hibariya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

APPROVE

@hibariya
Copy link
Contributor

hibariya commented Jun 4, 2024

/merge

@github-actions github-actions bot merged commit 40d3df7 into ruby:main Jun 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hibariya hibariya hibariya left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Little-Rubyist @hibariya