actionpack: Add missing methods to ActionController::Parameters #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tk0miya Thanks for your contribution! Please follow the instructions below for each change. Available commandsYou can use the following commands by commenting on this PR.
|
tk0miya
commented
Jun 12, 2024
- [::Kernel public] def to_s: () -> ::String
+ [::ActionController::Parameters public] def to_s: () -> ::String
- -
+ [::ActionController::Parameters public] def keys: () -> ::Array[untyped]
- -
+ [::ActionController::Parameters public] def key?: () -> bool
- -
+ [::ActionController::Parameters public] def has_key?: () -> bool
- -
+ [::ActionController::Parameters public] def values: () -> ::Array[untyped]
- -
+ [::ActionController::Parameters public] def has_value?: () -> bool
- -
+ [::ActionController::Parameters public] def empty?: () -> bool
- -
+ [::ActionController::Parameters public] def include?: (untyped) -> bool
- -
+ [::ActionController::Parameters public] def as_json: () -> ::String
- -
+ [::ActionController::Parameters public] def each_key: () { (untyped) -> untyped } -> ::Hash[untyped, untyped] | () -> ::Enumerator[untyped, self] |
tk0miya
force-pushed
the
actioncontroller_parameters_empty
branch
from
96bce67
to
63e74e8
Compare
Some methods for ActionController::Parameters has been missing because they're defined via delegation. This adds them manually. refs: https://github.com/rails/rails/blob/v6.0.6.1/actionpack/lib/action_controller/metal/strong_parameters.rb#L214-L215
tk0miya
force-pushed
the
actioncontroller_parameters_empty
branch
from
63e74e8
to
89576fd
Compare
|
/merge |
|
@ksss Thank you for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some methods for ActionController::Parameters has been missing because they're defined via delegation.
This adds them manually.
refs: https://github.com/rails/rails/blob/v6.0.6.1/actionpack/lib/action_controller/metal/strong_parameters.rb#L214-L215