Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MiniMagick v5.0 #629

Merged
merged 1 commit into from
Jul 27, 2024
Merged

Conversation

aki19035vc
Copy link
Contributor

Since MiniMagick v5.0 has been released, add types.

https://github.com/minimagick/minimagick/tree/v5.0.1

The README includes the following usage example,
but methods such as resize and format do not exist and there are hacked by method_missing.

image = MiniMagick::Image.open("input.jpg")
image.path
image.resize "100x100"
image.format "png"
image.write "output.png"

Since it is not possible to determine whether a method can be used or not depending on the version of ImageMagick being used, methods that are hacked with method_missing are not defined in the collection.

Since MiniMagick v5.0 has been released, add types.

https://github.com/minimagick/minimagick/tree/v5.0.1

The README includes the following usage example,
but methods such as resize and format do not exist and there are hacked by method_missing.

```ruby
image = MiniMagick::Image.open("input.jpg")
image.path
image.resize "100x100"
image.format "png"
image.write "output.png"
```

Since it is not possible to determine whether a method can be used or not depending on the version of ImageMagick being used,
methods that are hacked with method_missing are not defined in the collection.
@aki19035vc aki19035vc marked this pull request as ready for review July 27, 2024 04:45
Copy link

@aki19035vc Thanks for your contribution!

Please follow the instructions below for each change.
See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

  • /merge: Merge this PR if CI passes

mini_magick

You changed RBS files for an existing gem.
This gem does not have reviewers. So you can merge this PR immediately if the CI passes.
We recommend you add yourself to the reviewers for this gem.

@aki19035vc
Copy link
Contributor Author

/merge

@github-actions github-actions bot merged commit 0bf03b9 into ruby:main Jul 27, 2024
5 checks passed
@aki19035vc aki19035vc deleted the add_rbs_for_minimagick_v5 branch July 27, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant