Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed steep error points in ActiveRecord 6.1 #631

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Fixed steep error points in ActiveRecord 6.1 #631

merged 1 commit into from
Aug 2, 2024

Conversation

rhiroe
Copy link
Contributor

@rhiroe rhiroe commented Jul 28, 2024 •
edited
Loading

resolved #619

  • Symlink of _test/metadata.yaml in 6.0 to 6.1
  • Annotated User#articles definition using @dynamic and removed _test/steep_expectations.yml

@rhiroe rhiroe marked this pull request as ready for review July 28, 2024 01:38
@rhiroe
Copy link
Contributor Author

rhiroe commented Jul 28, 2024

I am not sure how Steep errors came to be ignored.
@tk0miya Any supplemental information would be appreciated.

@github-actions GitHub Actions
Copy link

@rhiroe Thanks for your contribution!

Please follow the instructions below for each change.
See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

  • /merge: Merge this PR if CI passes

activerecord

You changed RBS files for an existing gem.
You need to get approval from the reviewers of this gem.

@hibariya, @ksss, @Little-Rubyist, please review this pull request.
If this change is acceptable, please make a review comment including APPROVE from here.
Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR.
Just comment /merge to merge this PR.

@rhiroe rhiroe force-pushed the fix-619 branch 2 times, most recently from 14f2d53 to c2f4c7e Compare July 28, 2024 02:09
@tk0miya
Copy link
Contributor

tk0miya commented Jul 28, 2024

It's much better to use symlinks for these files than copying them.

@tk0miya
Copy link
Contributor

tk0miya commented Jul 29, 2024

Looks good. Thanks!

@rhiroe
Fixed steep error points in ActiveRecord 6.1
1ed6b83 
- Symlink of _test/metadata.yaml in 6.0 to 6.1
- Annotated `User#articles` definition using `@dynamic` and removed _test/steep_expectations.yml

These files are added in ruby#598
@rhiroe rhiroe changed the title Allow Steep errors as in 6.0 Fixed steep error points in ActiveRecord 6.1 Jul 29, 2024
ksss
ksss reviewed Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@ksss ksss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2024

Thanks for your review, @ksss!

@rhiroe, @ksss This PR is ready to be merged.
Just comment /merge to merge this PR.

@rhiroe
Copy link
Contributor Author

rhiroe commented Aug 2, 2024

/merge

@github-actions github-actions bot merged commit 343e5e8 into ruby:main Aug 2, 2024
4 checks passed
@rhiroe rhiroe deleted the fix-619 branch August 2, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksss ksss ksss left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests on activerecord v6.1 fail
3 participants
@rhiroe @tk0miya @ksss