-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(roo): Add types for roo #665
Conversation
> Gem version you want to add (MAJOR.MINOR is recommended. e.g. 4.2): > > 2.10 > Your GitHub account if you want to become the maintainer of RBS for this gem (default: skip adding you to the maintainer) > We recommentd to add your account to maintain the RBS actively. > See https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md#gem-reviewer > > sanfrecce-osaka > create gems/roo/2.10/roo.rbs > create gems/roo/2.10/_test/test.rb > create gems/roo/2.10/_test/metadata.yaml > create gems/roo/2.10/manifest.yaml > create gems/roo/_reviewers.yaml > > The boilerplate for roo gem has been generated. > Start writing the RBS! We recommend to focus on the main API of roo. > See the CONTRIBUTING.md for more information.
@sanfrecce-osaka Thanks for your contribution! Please follow the instructions below for each change. Available commandsYou can use the following commands by commenting on this PR.
|
Could you remove the submodule or explain why the submodule is necessary? Using submodules has been deprecated. I want to avoid using submodules if you do not have some strong reason. |
…o.git gems/roo/2.10/_src" This reverts commit 5ce1fd6. cf. ruby#665 (comment) > Could you remove the submodule or explain why the submodule is necessary? > > Using submodules has been deprecated. I want to avoid using submodules if you do not have some strong reason. You can merge this PR by yourself if this PR does not have the submodule.
Thank you for your feedback. |
/merge |
This PR adds rbs for roo gem.