Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(roo): Add types for roo #665

Merged
merged 9 commits into from
Sep 21, 2024
Merged

Conversation

sanfrecce-osaka
Copy link
Contributor

This PR adds rbs for roo gem.

> Gem version you want to add (MAJOR.MINOR is recommended. e.g. 4.2):
> > 2.10
> Your GitHub account if you want to become the maintainer of RBS for this gem (default: skip adding you to the maintainer)
> We recommentd to add your account to maintain the RBS actively.
> See https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md#gem-reviewer
> > sanfrecce-osaka
> create gems/roo/2.10/roo.rbs
> create gems/roo/2.10/_test/test.rb
> create gems/roo/2.10/_test/metadata.yaml
> create gems/roo/2.10/manifest.yaml
> create gems/roo/_reviewers.yaml
>
> The boilerplate for roo gem has been generated.
> Start writing the RBS! We recommend to focus on the main API of roo.
> See the CONTRIBUTING.md for more information.
Copy link

@sanfrecce-osaka Thanks for your contribution!

Please follow the instructions below for each change.
See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

  • /merge: Merge this PR if CI passes

roo

This RBS files are newly added.

You can merge this PR immediately if the CI passes.
Just comment /merge to merge this PR.


You changed non-gem files.

@pocke, please review and approve the changes.

@pocke
Copy link
Member

pocke commented Sep 17, 2024

Could you remove the submodule or explain why the submodule is necessary?

Using submodules has been deprecated. I want to avoid using submodules if you do not have some strong reason.
You can merge this PR by yourself if this PR does not have the submodule.

…o.git gems/roo/2.10/_src"

This reverts commit 5ce1fd6.

cf. ruby#665 (comment)

> Could you remove the submodule or explain why the submodule is necessary?
>
> Using submodules has been deprecated. I want to avoid using submodules if you do not have some strong reason. You can merge this PR by yourself if this PR does not have the submodule.
@sanfrecce-osaka
Copy link
Contributor Author

sanfrecce-osaka commented Sep 21, 2024

Could you remove the submodule or explain why the submodule is necessary?

Using submodules has been deprecated. I want to avoid using submodules if you do not have some strong reason. You can merge this PR by yourself if this PR does not have the submodule.

Thank you for your feedback.
I reverted sanfrecce-osaka@5ce1fd6 🙏

@sanfrecce-osaka
Copy link
Contributor Author

/merge

@github-actions github-actions bot merged commit 257e560 into ruby:main Sep 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants