Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

activemodel: Add ActiveModel::API #695

Merged
merged 1 commit into from
Oct 28, 2024
Merged

activemodel: Add ActiveModel::API #695

merged 1 commit into from
Oct 28, 2024

Conversation

tk0miya
Copy link
Contributor

@tk0miya tk0miya commented Oct 22, 2024

ActiveModel::API has been added since v7.0.

refs: rails/rails#43223

@tk0miya
activemodel: Add ActiveModel::API
4b2ae79 
ActiveModel::API has been added since v7.0.

refs: rails/rails#43223
@github-actions GitHub Actions
Copy link

@tk0miya Thanks for your contribution!

Please follow the instructions below for each change.
See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

  • /merge: Merge this PR if CI passes

activemodel

You changed RBS files for an existing gem.
You need to get approval from the reviewers of this gem.

@hibariya, @ksss, please review this pull request.
If this change is acceptable, please make a review comment including APPROVE from here.
Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR.
Just comment /merge to merge this PR.

ksss
ksss reviewed Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@ksss ksss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE

@github-actions GitHub Actions
Copy link

Thanks for your review, @ksss!

@tk0miya, @ksss This PR is ready to be merged.
Just comment /merge to merge this PR.

@tk0miya
Copy link
Contributor Author

tk0miya commented Oct 28, 2024

/merge

@github-actions github-actions bot merged commit dcc30ea into ruby:main Oct 28, 2024
5 checks passed
@tk0miya tk0miya deleted the activemodel/api branch October 28, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksss ksss ksss left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tk0miya @ksss