railties: Move the definition of PluginGenerator.app_path to railties.rbs #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tk0miya Thanks for your contribution! Please follow the instructions below for each change. Available commandsYou can use the following commands by commenting on this PR.
|
ksss
reviewed
Oct 28, 2024
|
ah, sorry. It's mistake... I'd like to do only moving |
tk0miya
force-pushed
the
railties/railties.rbs
branch
from
7e1b663
to
fef1771
Compare
|
Now I busted zombies from #692. |
ksss
reviewed
Oct 30, 2024
gems/railties/6.0/railties.rbs
Outdated
Comment on lines
4
to
5
| # It is necessary to satisfy alias target. | ||
| # TODO: Define this method to correct place. |
….rbs As a preparation of ruby#693, this moves the definition of `Rails::Generator::PluginGenerator#app_path` to railties.rbs
tk0miya
force-pushed
the
railties/railties.rbs
branch
from
fef1771
to
6aa1df0
Compare
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a preparation of #693, this moves the definition of
Rails::Generator::PluginGenerator#app_pathto railties.rbs