Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

activerecord: Remove unnecessary patches to other gems #711

Merged
merged 1 commit into from
Oct 31, 2024
Merged

activerecord: Remove unnecessary patches to other gems #711

merged 1 commit into from
Oct 31, 2024

Conversation

tk0miya
Copy link
Contributor

@tk0miya tk0miya commented Oct 30, 2024

No description provided.

@github-actions GitHub Actions
Copy link

@tk0miya Thanks for your contribution!

Please follow the instructions below for each change.
See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

  • /merge: Merge this PR if CI passes

activerecord

You changed RBS files for an existing gem.
You need to get approval from the reviewers of this gem.

@hibariya, @ksss, @Little-Rubyist, please review this pull request.
If this change is acceptable, please make a review comment including APPROVE from here.
Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR.
Just comment /merge to merge this PR.

tk0miya
tk0miya commented Oct 30, 2024
View reviewed changes
gems/activerecord/6.0/patch.rbs
Comment on lines -38 to -41
module Gem
class Version
end
end
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/ruby/rbs/blob/master/core/rubygems/version.rbs#L163

tk0miya
tk0miya commented Oct 30, 2024
View reviewed changes
gems/activerecord/6.0/patch.rbs
Comment on lines -33 to -34
class SimpleDelegator
end
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/ruby/rbs/blob/master/stdlib/delegate/0/simple_delegator.rbs#L69

ksss
ksss reviewed Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@ksss ksss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE

gems/activerecord/6.1/manifest.yaml Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Thanks for your review, @ksss!

@tk0miya, @ksss This PR is ready to be merged.
Just comment /merge to merge this PR.

@tk0miya tk0miya force-pushed the activerecord/remove_unnecessary_patches branch from 0aced33 to 21279ec Compare October 30, 2024 17:09
@tk0miya tk0miya force-pushed the activerecord/remove_unnecessary_patches branch from 21279ec to 5f1b19a Compare October 30, 2024 17:10
@tk0miya
Copy link
Contributor Author

tk0miya commented Oct 30, 2024

Now I replaced the symlink with a real file.

@ksss
Copy link
Collaborator

ksss commented Oct 31, 2024

LGTM!

@tk0miya
Copy link
Contributor Author

tk0miya commented Oct 31, 2024

/merge

@github-actions GitHub Actions
Copy link

/merge command failed.

This PR is not approved yet by the reviewers. Please get approval from the reviewers.

See the Actions tab for detail.

@tk0miya
Copy link
Contributor Author

tk0miya commented Oct 31, 2024

@ksss re-APPROVE is needed after the change. Could you review this again?
Thanks as always.

ksss
ksss reviewed Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@ksss ksss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE

@github-actions GitHub Actions
Copy link

Thanks for your review, @ksss!

@tk0miya, @ksss This PR is ready to be merged.
Just comment /merge to merge this PR.

@tk0miya
Copy link
Contributor Author

tk0miya commented Oct 31, 2024

/merge

@github-actions github-actions bot merged commit 63c49dc into ruby:main Oct 31, 2024
4 checks passed
@tk0miya tk0miya deleted the activerecord/remove_unnecessary_patches branch November 1, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksss ksss ksss left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tk0miya @ksss