Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix termination check of x in * #1081

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tompng
Copy link
Member

@tompng tompng commented Jan 29, 2025

Fix #1080

It is hard to distinguish multiplication from pattern match from tokens.
Token * are both [[3, 0], :on_op, "*", BEG].

# x in *
<<A; x in
A
*
# string * value(missing)
<<A\
A
*

So in this pull request, treat this :on_op, '*', BEG as should_continue == true only when the whole code is syntax valid.

Also fixes x in ** x => * x => ** and def f(*,**)=f *, **

@tompng tompng added the bug Something isn't working label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

Unable to execute x in *
1 participant