Skip to content

Commit

Permalink
Bump mmtk-core
Browse files Browse the repository at this point in the history
Fixes a bug where there is an infinite loop when MMTK_HEAP_MIN is small.
  • Loading branch information
peterzhu2118 committed Jan 21, 2025
1 parent a725b95 commit 12c7ede
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 7 deletions.
4 changes: 2 additions & 2 deletions gc/mmtk/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion gc/mmtk/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ features = ["is_mmtk_object", "object_pinning", "sticky_immix_non_moving_nursery

# Uncomment the following lines to use mmtk-core from the official repository.
git = "https://github.com/mmtk/mmtk-core.git"
rev = "c61e6c84f97ddb91e47d76914af2f7e462f1c7f8"
rev = "051bc7470feef915c445305301e6113f86d3957b"

# Uncomment the following line to use mmtk-core from a local repository.
# path = "../../../mmtk-core"
Expand Down
7 changes: 3 additions & 4 deletions test/mmtk/test_configuration.rb
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,9 @@ def test_MMTK_HEAP_MIN
assert_equal(1 * 1024 * 1024, GC.config[:mmtk_heap_min])
RUBY

# TODO: uncomment this test when the infinite loop is fixed
# assert_separately([{ "MMTK_HEAP_MODE" => "dynamic", "MMTK_HEAP_MIN" => "1" }], <<~RUBY)
# assert_equal(1, GC.config[:mmtk_heap_min])
# RUBY
assert_separately([{ "MMTK_HEAP_MODE" => "dynamic", "MMTK_HEAP_MIN" => "1" }], <<~RUBY)
assert_equal(1, GC.config[:mmtk_heap_min])
RUBY

assert_separately([{ "MMTK_HEAP_MODE" => "dynamic", "MMTK_HEAP_MIN" => "10MiB", "MMTK_HEAP_MAX" => "1GiB" }], <<~RUBY)
assert_equal(10 * 1024 * 1024, GC.config[:mmtk_heap_min])
Expand Down

0 comments on commit 12c7ede

Please sign in to comment.