implement talking SSL to the proxy too #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
commented
May 9, 2022
| @@ -1024,7 +1028,13 @@ def connect | |||
| debug "opened" | |||
| if use_ssl? | |||
| if proxy? | |||
| plain_sock = BufferedIO.new(s, read_timeout: @read_timeout, | |||
| if @proxy_use_ssl | |||
| proxy_sock = OpenSSL::SSL::SSLSocket.new(s) | |||
There was a problem hiding this comment.
this probably needs some more work, especially when it comes to verification etc, but it's a start :)
There was a problem hiding this comment.
@evgeni, I try to avoid code changes.
There was a problem hiding this comment.
Not sure what you mean by that?
|
Would be good if someone, like @peterzhu2118 or @BurdetteLamar can leave a commit for this change? |
evgeni
force-pushed
the
ssl-proxies
branch
2 times, most recently
from
c1310af
to
726803c
Compare
|
👍 |
|
Thanks! |
richardmarbach
added a commit
to richardmarbach/faraday-net_http
that referenced
this pull request
Nov 11, 2024
net-http version 0.5.0 finally introduced TLS proxy support: ruby/net-http#55 https://github.com/ruby/net-http/releases/tag/v0.5.0
richardmarbach
added a commit
to richardmarbach/faraday-net_http
that referenced
this pull request
Nov 11, 2024
net-http version 0.5.0 finally introduced TLS proxy support: ruby/net-http#55 https://github.com/ruby/net-http/releases/tag/v0.5.0
olleolleolle
pushed a commit
to lostisland/faraday-net_http
that referenced
this pull request
Nov 11, 2024
* Add HTTPS Proxy support net-http version 0.5.0 finally introduced TLS proxy support: ruby/net-http#55 https://github.com/ruby/net-http/releases/tag/v0.5.0 * Add mininum net-http version SSL proxies only supported in net-http 0.5.0 or above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.ruby-lang.org/issues/16482