pkey: disallow {DH,DSA,EC,RSA}.new without arguments on OpenSSL 3.0 #848
+79
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a useful macro to avoid scattering *_PREREQ() checks everywhere. Currently, the macro is defined for OpenSSL 3.0 or later only. I think it is possible that LibreSSL may adopt it in the future.
When OpenSSL::PKey::{DH,DSA,EC,RSA}.new is called without any arguments,
it sets up an empty corresponding low-level struct and wraps it in an
EVP_PKEY. This form has been supported so that users can fill the fields
later using low-level setter methods such as OpenSSL::PKey::RSA#set_key.
Such setter methods are not compatible with OpenSSL 3.0 or later, where
pkeys are immutable once created. This means that the ability to create
an empty instance is useless. Let's remove it and raise ArgumentError if
attempted.
rhenium
force-pushed
the
ky/pkey-disallow-empty-init
branch
from
63e9d09 to
43aa5ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
OpenSSL::PKey::{DH,DSA,EC,RSA}.newis called without any arguments, it sets up an empty corresponding low-level struct and wraps it in anEVP_PKEY. This form has been supported so that users can fill the fields later using low-level setter methods such asOpenSSL::PKey::RSA#set_key.Such setter methods are not compatible with OpenSSL 3.0 or later, where pkeys are immutable once created. This means that the ability to create an empty instance is useless. Let's remove it and raise
ArgumentErrorif attempted.Related:
OpenSSL::PKey::DSA.new.to_s#845