jruby: safer engine version resolution #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kares
changed the title
kares
commented
Feb 13, 2025
| private static final String DUMMY_VERSION = "0.0"; | ||
|
|
||
| public void load(final Ruby runtime, boolean wrap) { | ||
| RubyModule psych = runtime.defineModule("Psych"); | ||
|
|
||
| // load version from properties packed with the jar | ||
| Properties props = new Properties(); | ||
| try( InputStream is = runtime.getJRubyClassLoader().getResourceAsStream("META-INF/maven/org.snakeyaml/snakeyaml-engine/pom.properties") ) { | ||
| props.load(is); | ||
| try( InputStream is = SpecVersion.class.getResourceAsStream(POM_PROPERTIES) ) { |
There was a problem hiding this comment.
using an actual class from the .jar we're trying to locate the resource from should work more reliably (for the common gem case this is going to be the same as before with runtime.getJRubyClassLoader()).
headius
approved these changes
Feb 13, 2025
| private static final String DUMMY_VERSION = "0.0"; | ||
|
|
||
| public void load(final Ruby runtime, boolean wrap) { | ||
| RubyModule psych = runtime.defineModule("Psych"); | ||
|
|
||
| // load version from properties packed with the jar | ||
| Properties props = new Properties(); | ||
| try( InputStream is = runtime.getJRubyClassLoader().getResourceAsStream("META-INF/maven/org.snakeyaml/snakeyaml-engine/pom.properties") ) { | ||
| props.load(is); | ||
| try( InputStream is = SpecVersion.class.getResourceAsStream(POM_PROPERTIES) ) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while also retaining the original version number in the
SNAKEYAML_VERSIONconstantcloses #711