Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing RDoc::RubygemsHook API for gem server #1270

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Add missing RDoc::RubygemsHook API for gem server #1270

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4681de5
Fix: #1269 `gem server` doesn't work because `Gem::Rdoc.load_rdoc` ra…
mterada1228 Jan 5, 2025
4c9b663
Apply suggestions from code review
mterada1228 Jan 5, 2025
03e1f28
add `rdoc_installed?` and `ri_installed?`
mterada1228 Jan 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/rdoc/rubygems_hook.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,10 @@ class RubygemsHook

attr_accessor :generate_rdoc, :generate_ri, :force

class << self
attr_accessor :rdoc_version
end

mterada1228 marked this conversation as resolved.
Show resolved Hide resolved
def self.default_gem?
!File.exist?(File.join(__dir__, "..", "rubygems_plugin.rb"))
end
Expand Down Expand Up @@ -310,5 +314,9 @@ def self.generation_hook installer, specs
# Generate document for compatibility if this is a default gem.
RubyGemsHook.generate(installer, specs)
end

def self.load_rdoc
@rdoc_version = RubyGemsHook.load_rdoc
end
mterada1228 marked this conversation as resolved.
Show resolved Hide resolved
end
end
Loading