Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(TODO: wait for reline_0.5.0.pre)
Fixes #611 and #621
Split logic and state of autocompletion and tab completion
Before
Reline has tab complete and autocomplete.
Tab complete uses
Autocomplete uses
It's a separate feature but uses same instance variable
@completion_state
that making hard to fix some bugs.After
Tab complete uses
Autocomplete uses
State is separated. Logic is also separated. Now we can remove redundant proc calls and fix #611 #621
completion_journey_data
completion_journey_data
is an API for dialog proc, defined in DialogProcScope. We need to keep compatibility.It was an instance variable but changed to a method that calculates from
@completion_journey_state
.