Ractor compat #62
Open
Ractor compat #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, this is beautiful and likely negates the needs for the immutable DNS primitives I was working on, thanks! |
HoneyryderChuck
force-pushed
the
ractor-compat
branch
from
e62c312 to
65efd6a
Compare
nobu
reviewed
Nov 16, 2024
mutable constants can't be shared across ractors; this changes that design to define the required variables as constants on the Resource class, which makes them reachable using ractors; the ClassHash is kept in order not to break integrations relying on its existence, but under the hood it's doing the same thing
HoneyryderChuck
force-pushed
the
ractor-compat
branch
from
65efd6a to
fc34b8a
Compare
|
@nobu anything else worth addressing? |
|
@akr can I ask for a review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR refactores
ClassHashapproach to be ractor-safe while keeping backwards compatibility. It also freezes the content of default_config_hash, which should not be mutable anyway (and this also makes it shareable across ractors).