Skip to content

Commit

Permalink
fix: build
Browse files Browse the repository at this point in the history
  • Loading branch information
route committed Jan 7, 2025
1 parent 70768db commit 1957624
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 4 deletions.
7 changes: 6 additions & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: [2.7, "3.0", 3.1, 3.2, 3.3]
ruby: ["2.7", "3.0", "3.1", "3.2", "3.3", "3.4"]
runs-on: ubuntu-latest
env:
FERRUM_PROCESS_TIMEOUT: 25
Expand All @@ -31,6 +31,11 @@ jobs:
with:
chrome-version: stable

- name: Fix GA Chrome Permissions
run: |
sudo chown root:root /opt/hostedtoolcache/setup-chrome/chromium/stable/x64/chrome-sandbox
sudo chmod 4755 /opt/hostedtoolcache/setup-chrome/chromium/stable/x64/chrome-sandbox
- name: Run tests
run: |
mkdir -p /tmp/cuprite
Expand Down
4 changes: 2 additions & 2 deletions cuprite.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@ Gem::Specification.new do |s|

s.required_ruby_version = ">= 2.7.0"

s.add_runtime_dependency "capybara", "~> 3.0"
s.add_runtime_dependency "ferrum", "~> 0.16.0"
s.add_dependency "capybara", "~> 3.0"
s.add_dependency "ferrum", "~> 0.16.0"
end
3 changes: 2 additions & 1 deletion lib/capybara/cuprite/driver.rb
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,8 @@ def set_cookie(name, value, options = {})

def remove_cookie(name, **options)
options[:domain] = default_domain if options.empty?
browser.cookies.remove(**options.merge(name: name))
options = options.merge(name: name)
browser.cookies.remove(**options)
end

def clear_cookies
Expand Down

0 comments on commit 1957624

Please sign in to comment.