WIP: Hide unneeded "Attach Files" button when creating a new FAQ question - Resolves #5070 #5078
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5070
Description
An unneeded "Attach Files" button was appearing on the form to create a new FAQ when logged in as an administrator, as described in #5070.
Digging in the code (and some maintainer help!) revealed that the relevant row of buttons is a Trix toolbar. The only way we could figure out how to hide the button was to do it via the CSS. However, after adding and testing the button-hiding code in
actiontext.scss
, we found that the changes weren't showing live. (It's not clearactiontext.scss
is actually getting used anywhere?)Importing
actiontext.scss
intoapplication.scss
fixed this... but maybe someone with better knowledge of the codebase can suggest a cleaner approach?Big thanks to Albert and Rachel at the SCaLE workshop, who both sat and dug around in the code with me to find a solution 💫
This Medium article was also a helpful reference.
Type of change
How Has This Been Tested?
Screenshots
"Attach Files" button is no longer visible in the list of toolbar buttons below the input field.