Unconfirmed email profile should return 404 #5143
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinsomicrote
force-pushed
the
unconfirmed-email-profile
branch
from
9dd517e
to
c4aab95
Compare
|
cc @martinemde |
martinemde
reviewed
Oct 18, 2024
segiddins
reviewed
Oct 19, 2024
martinemde
approved these changes
Oct 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5143 +/- ##
==========================================
- Coverage 96.05% 93.21% -2.85%
==========================================
Files 429 429
Lines 9106 9167 +61
==========================================
- Hits 8747 8545 -202
- Misses 359 622 +263 ☔ View full report in Codecov by Sentry. |
segiddins
approved these changes
Oct 20, 2024
martinemde
force-pushed
the
unconfirmed-email-profile
branch
from
2958b9f
to
4356fc8
Compare
- Added a check for profiles whose email has not been confirmed, so the show page can return 404 for such profiles
Co-authored-by: Martin Emde <[email protected]>
Use confirmed scope for finding user by slug so there is no need checking the user record directly
martinemde
force-pushed
the
unconfirmed-email-profile
branch
from
4356fc8
to
b965af5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to view the profile page of a user whose email has not been confirmed. To resolve #5079, this PR returns a 404 error page for the profile page when the email has not been confirmed.