Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organization index and show #5187

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

martinemde
Copy link
Member

Index is a section of the dashboard.
Show is the organization view page.

We may need to separate out the private and public view of an org, but this is a rough start.

@martinemde martinemde force-pushed the martinemde/organization-show-and-index branch from a7dd8f1 to ac32613 Compare October 31, 2024 20:39
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 30.57851% with 84 lines in your changes missing coverage. Please review.

Project coverage is 16.56%. Comparing base (4aa3425) to head (5deb9bb).

Files with missing lines Patch % Lines
app/views/components/card/timeline_component.rb 0.00% 28 Missing ⚠️
...pp/controllers/organizations/members_controller.rb 42.10% 22 Missing ⚠️
app/controllers/organizations_controller.rb 37.50% 15 Missing ⚠️
app/models/organization.rb 0.00% 11 Missing ⚠️
app/controllers/organizations/gems_controller.rb 75.00% 3 Missing ⚠️
app/helpers/layout_hepler.rb 40.00% 3 Missing ⚠️
app/controllers/rubygems_controller.rb 0.00% 1 Missing ⚠️
app/policies/organization_policy.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5187       +/-   ##
===========================================
- Coverage   96.85%   16.56%   -80.29%     
===========================================
  Files         456      460        +4     
  Lines        9511    12017     +2506     
===========================================
- Hits         9212     1991     -7221     
- Misses        299    10026     +9727     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martinemde martinemde force-pushed the martinemde/organization-show-and-index branch 2 times, most recently from 23b87bc to 82e857d Compare November 9, 2024 23:36
@martinemde martinemde changed the base branch from master to colby/organization-onboarding November 9, 2024 23:37
@martinemde martinemde force-pushed the martinemde/organization-show-and-index branch 2 times, most recently from 8521bc3 to d796b1b Compare November 11, 2024 05:31
@martinemde martinemde force-pushed the martinemde/organization-show-and-index branch 2 times, most recently from cc307c5 to 8b9ea90 Compare November 14, 2024 04:22
@martinemde martinemde marked this pull request as ready for review November 14, 2024 04:22
Base automatically changed from colby/organization-onboarding to master November 14, 2024 06:16
Index is a section of the dashboard.
Show is the organization view page.
Edit is organization settings
@colby-swandale colby-swandale force-pushed the martinemde/organization-show-and-index branch from 8b9ea90 to 5deb9bb Compare November 14, 2024 06:59
Copy link
Member

@colby-swandale colby-swandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, but the CodeCov is picking up that we're missing a fair amount of tests for the various paths being added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants