Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update git url before cloning enrichment plugin #160

Merged
merged 5 commits into from
Jul 31, 2024
Merged

chore: update git url before cloning enrichment plugin #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f9cbfd9
chore: update git url before cloning enrichment plugin
satishrudderstack Jul 31, 2024
010f1f5
fix typo
satishrudderstack Jul 31, 2024
00b2840
add .git to docker ignore
satishrudderstack Jul 31, 2024
c0e5444
update other workflow
satishrudderstack Jul 31, 2024
721238e
ignore .git at all levels
satishrudderstack Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@ venv
.coverage
*.swp
*.log
**/.git
3 changes: 2 additions & 1 deletion .github/workflows/pr-onto-dev.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ jobs:
docker login --username rudderlabs --password '${{ secrets.DOCKER_HUB_PASSWORD }}'
export VERSION=${{ steps.branch-name.outputs.current_branch }}
rm -rf rudder-alerta-enrichment-plugin
git clone -b "$(cat RUDDER_ENRICH_PLUGIN_BRANCH_NAME)" https://${{ secrets.PAT_USERNAME }}:${{ secrets.PAT }}@github.com/rudderlabs/rudder-alerta-enrichment-plugin.git
git config --global url."https://${{secrets.PAT}}:[email protected]/rudderlabs".insteadOf "https://github.com/rudderlabs"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also consider https://github.com/actions/checkout

git clone -b "$(cat RUDDER_ENRICH_PLUGIN_BRANCH_NAME)" https://github.com/rudderlabs/rudder-alerta-enrichment-plugin.git
docker build --no-cache --build-arg=COMMIT_ID_VALUE="$(git log --format="%H" -n 1)" -t rudderlabs/alerta:$VERSION .
docker push rudderlabs/alerta:$VERSION
rm -rf rudder-alerta-enrichment-plugin
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/push-onto-master.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ jobs:
docker login --username rudderlabs --password '${{ secrets.DOCKER_HUB_PASSWORD }}'
export VERSION=${{steps.version_check_staging.outputs.releaseVersion}}
rm -rf rudder-alerta-enrichment-plugin
git clone -b "$(cat RUDDER_ENRICH_PLUGIN_BRANCH_NAME)" https://${{ secrets.PAT_USERNAME }}:${{ secrets.PAT }}@github.com/rudderlabs/rudder-alerta-enrichment-plugin.git
git config --global url."https://${{secrets.PAT}}:[email protected]/rudderlabs".insteadOf "https://github.com/rudderlabs"
git clone -b "$(cat RUDDER_ENRICH_PLUGIN_BRANCH_NAME)" https://github.com/rudderlabs/rudder-alerta-enrichment-plugin.git
docker build --no-cache --build-arg=COMMIT_ID_VALUE="$(git log --format="%H" -n 1)" -t rudderlabs/alerta:$VERSION .
docker push rudderlabs/alerta:$VERSION
rm -rf rudder-alerta-enrichment-plugin
Expand Down
Loading