fix: race condition for err variable when statsd start is called (#44)

rudderlabs · May 8, 2023 · 5702038 · 5702038
1 parent 03bc460
commit 5702038
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/.gitignore b/.gitignore
@@ -14,3 +14,4 @@ coverage.html
 *.orig
 **/gomock_reflect_*/*
 ginkgo.report
+vendor/
diff --git a/stats/statsd.go b/stats/statsd.go
@@ -24,7 +24,7 @@ type statsdStats struct {
 	backgroundCollectionCancel func()
 }
 
-func (s *statsdStats) Start(ctx context.Context, goFactory GoRoutineFactory) (err error) {
+func (s *statsdStats) Start(ctx context.Context, goFactory GoRoutineFactory) error {
 	if !s.config.enabled.Load() {
 		return nil
 	}
@@ -34,6 +34,7 @@ func (s *statsdStats) Start(ctx context.Context, goFactory GoRoutineFactory) (er
 
 	// NOTE: this is to get at least a dummy client, even if there is a failure.
 	// So, that nil pointer error is not received when client is called.
+	var err error
 	s.state.client.statsd, err = statsd.New(s.state.conn, s.statsdConfig.statsdTagsFormat(), s.statsdConfig.statsdDefaultTags())
 	if err == nil {
 		s.logger.Info("StatsD client setup succeeded.")
-Original file line number
+Diff line change
@@ Expand Up / @@ -14,3 +14,4 @@ coverage.html @@
     *.orig
     **/gomock_reflect_*/*
     ginkgo.report
+    vendor/