chore: hide zoho detination setting for vdmv2 #1913
Conversation
WalkthroughThe pull request updates the Zoho destination configuration by adding a new Changes
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1913 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 53 53
Branches 7 7
=========================================
Hits 53 53 ☔ View full report in Codecov by Sentry. |
am6010
requested review from
lvrach,
cisse21,
debanjan97,
ssbeefeater,
ItsSudip,
sandeepdsvs,
krishna2020 and
1abhishekpandey
as code owners
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/configurations/destinations/zoho/ui-config.json (1)
88-96: Optional Configuration Settings: Note Text Improvement.
The addition of the"preRequisites"block to the"addDefaultDuplicateCheck"field is correctly implemented. However, the note contains a redundancy ("as primary" is repeated). Consider revising it for clarity; for example, change it to:
"Rudderstack will use the identifier field as the primary duplicate check field."
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/configurations/destinations/zoho/ui-config.json(4 hunks)
🔇 Additional comments (3)
src/configurations/destinations/zoho/ui-config.json (3)
70-78: Module Settings: Valid use of preRequisites.
The added"preRequisites"block with the"featureFlags"for the"module"field is clear and consistent with gating the configuration based on feature flags. It aligns well with the PR objective by conditionally hiding settings based on the"AMP_vdm-next"flag.
130-138: Zoho Trigger Option: Consistent Feature Flag Handling.
The updated field now explicitly sets the"default"to"None"and includes the new"preRequisites"block with the"AMP_vdm-next"feature flag. This implementation is consistent with the overall approach, ensuring that the setting is hidden when the flag is disabled.
167-175: Field Level Specification: Clear Prerequisite Addition.
The changes involving the"Module Specific Multi Select Pick List Field Action Mapping"field correctly add a"preRequisites"block with the same feature flag. This ensures consistency across configuration sections while controlling visibility based on"AMP_vdm-next".
am6010
changed the title
am6010
changed the title
am6010
force-pushed
the
chore.rev-1470
branch
from
f4485cd to
53a4cae
Compare
| @@ -140,7 +164,15 @@ | |||
| "type": "redirect", | |||
| "redirectGroupKey": "multiSelectFieldLevelDecision", | |||
| "label": "Module Specific Multi Select Pick List Field Action Mapping", | |||
| "note": "Map Zoho Multi Select Pick List Field Action To Append or Replace" | |||
| "note": "Map Zoho Multi Select Pick List Field Action To Append or Replace", | |||
There was a problem hiding this comment.
Is the entire section of fields mapping getting hidden ? can you attach screenshots of destination page (with minimized sections) in the PR description
What are the changes introduced in this PR?
Write a brief explainer on your code changes.
What is the related Linear task?
Resolves INT-XXX
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new checks got introduced or modified in test suites. Please explain the changes.
N/A
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
I have executed schemaGenerator tests and updated schema if needed
Are sensitive fields marked as secret in definition config?
My test cases and placeholders use only masked/sample values for sensitive fields
Is the PR limited to 10 file changes & one task?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.
Summary by CodeRabbit