Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: onboard am to proxy #4110

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

yashasvibajpai
Copy link
Member

What are the changes introduced in this PR?

Write a brief explainer on your code changes.

What is the related Linear task?

Resolves INT-3215

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@yashasvibajpai yashasvibajpai self-assigned this Feb 24, 2025
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.17%. Comparing base (b35a651) to head (6e4ada0).
Report is 15 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4110      +/-   ##
===========================================
+ Coverage    91.12%   91.17%   +0.04%     
===========================================
  Files          631      633       +2     
  Lines        32938    33123     +185     
  Branches      7802     7839      +37     
===========================================
+ Hits         30015    30200     +185     
- Misses        2673     2705      +32     
+ Partials       250      218      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@yashasvibajpai yashasvibajpai marked this pull request as ready for review February 26, 2025 06:38
@yashasvibajpai yashasvibajpai requested review from a team and sivashanmukh as code owners February 26, 2025 06:38
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@koladilip
Copy link
Contributor

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@yashasvibajpai
Copy link
Member Author

Quality Gate Passed Quality Gate passed

Issues 1 New issue 0 Accepted issues
Measures 0 Security Hotspots 100.0% Coverage on New Code 0.0% Duplication on New Code
See analysis details on SonarQube Cloud

new sonar issue

it gets fixed with the refactor u shared

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants