-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace secrets in test cases with constants #4133
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4133 +/- ##
========================================
Coverage 91.21% 91.21%
========================================
Files 631 631
Lines 33076 33084 +8
Branches 7827 7831 +4
========================================
+ Hits 30170 30178 +8
- Misses 2658 2690 +32
+ Partials 248 216 -32 ☔ View full report in Codecov by Sentry. |
Allure Test reports for this run are available at: |
f30c79e
to
de8d65f
Compare
Allure Test reports for this run are available at: |
|
Allure Test reports for this run are available at: |
What are the changes introduced in this PR?
What is the related Linear task?
Resolves INT-3330
Please explain the objectives of your changes below
SonarCloud raises 5000+ security issues in transformer repo. One of the reasons for this issue is hardcoded (albeit dummy) secrets in test cases.
Although this is not a severe security concern, it gets difficult to wade all the noise and find P0 security issues which might've been raised by sonarcloud.
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
No
Any new dependencies introduced with this change?
No
Any new generic utility introduced or modified. Please explain the changes.
Script to replace secrets in test files.
Any technical or performance related pointers to consider with the change?
No
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added in new readability format?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.